feat(mcp): handle ToolContext in MCP tool callbacks #2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement the new ToolCallback.call(String, ToolContext) method in both Sync and Async MCP tool callbacks. - Since MCP tools don't support tool context, the implementation ignores the context parameter and delegates to the existing call(String) method. Added test to verify the behavior. Resolves spring-projects#2378 Signed-off-by: Christian Tzolov <[email protected]>
| } | ||
|
|
||
| @Override | ||
| public String call(String toolArguments, ToolContext toolContext) { |
There was a problem hiding this comment.
I would like to understand why the default implementation of call(String, ToolContext) at ToolCallback is not enough as it handles null check and call(String) eventually.
There was a problem hiding this comment.
The default implementation doesn't support non-empty ToolContext parameters and throws an exception. Here we override this to just ignore the tool-context parameter as it doesn't make sense for MCP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2378